changing state of an LED using a pushbutton leads to unstable result Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?Button state changing randomlyUnstable reading from pushbutton on digital pinServo Control using PushbuttonHow can I setup a LED state change with push buttons?i am unable to make a correct program using the pushbutton to toggle LED on/off?When a pushbutton and sensor are in a certain state, do something for a certain period of time (15 seconds)Button and switch to turn on and off LED and changing after timePushButton as LED Switch (does not work)Why did my pushbutton LED circuit work when my wiring was wrong?Using a pushbutton to power Arduino on and off

When a candle burns, why does the top of wick glow if bottom of flame is hottest?

Significance of Cersei's obsession with elephants?

How can I use the Python library networkx from Mathematica?

How to react to hostile behavior from a senior developer?

Did MS DOS itself ever use blinking text?

Can melee weapons be used to deliver Contact Poisons?

Around usage results

Why does the resolve message appear first?

Why are there no cargo aircraft with "flying wing" design?

Using audio cues to encourage good posture

What does this Jacques Hadamard quote mean?

How come Sam didn't become Lord of Horn Hill?

What do you call the main part of a joke?

For a new assistant professor in CS, how to build/manage a publication pipeline

How to find all the available tools in mac terminal?

representation of vector and matrix in latex

How do I stop a creek from eroding my steep embankment?

また usage in a dictionary

Is CEO the profession with the most psychopaths?

Has negative voting ever been officially implemented in elections, or seriously proposed, or even studied?

Closed form of recurrent arithmetic series summation

How to answer "Have you ever been terminated?"

What causes the direction of lightning flashes?

Can anything be seen from the center of the Boötes void? How dark would it be?



changing state of an LED using a pushbutton leads to unstable result



Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)
Announcing the arrival of Valued Associate #679: Cesar Manara
Unicorn Meta Zoo #1: Why another podcast?Button state changing randomlyUnstable reading from pushbutton on digital pinServo Control using PushbuttonHow can I setup a LED state change with push buttons?i am unable to make a correct program using the pushbutton to toggle LED on/off?When a pushbutton and sensor are in a certain state, do something for a certain period of time (15 seconds)Button and switch to turn on and off LED and changing after timePushButton as LED Switch (does not work)Why did my pushbutton LED circuit work when my wiring was wrong?Using a pushbutton to power Arduino on and off










1















I am trying to run this code:



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT);


void loop()

buttonState = digitalRead(buttonPin);


if (buttonState = HIGH && lastButtonState != buttonState)
flag = !flag;
if (flag)
digitalWrite(ledPin13, LOW);
else
digitalWrite(ledPin13, HIGH);





on this SimulIDE model:





<circuit reactStep="50" animate="0" type="simulide_0.1" noLinStep="10" noLinAcc="5" speed="1000000">

Node-16:
<item labelrot="0" y="-204" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-220" labelx="-16" labely="-24" Show_id="false" objectName="Node-16" itemtype="Node" id="Node-16" rotation="0"/>

Arduino Uno-4:
<item hflip="1" Show_id="true" valLabely="0" itemtype="Arduino" vflip="1" labelx="0" objectName="Arduino Uno-4" labely="-20" y="-244" Ser_Port="false" labelrot="0" rotation="0" Program="../../Google Drive/Active projects/SRL/Students/Damian2019/Simulation/20190409/noDelay_20190409/noDelay_20190409.ino.standard.hex" Ser_Monitor="false" id="Arduino Uno-4" valLabelx="0" Mhz="16" valLabRot="0" x="-148"/>

Resistor-3:
<item Unit=" O" hflip="1" Show_id="false" valLabely="6" itemtype="Resistor" Show_res="true" vflip="1" labelx="-12" objectName="Resistor-3" labely="-24" y="-164" labelrot="0" rotation="-90" Resistance="100" id="Resistor-3" valLabelx="-16" valLabRot="0" x="-220"/>

Push-2:
<item labelrot="0" y="-308" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-100" labelx="-16" labely="-24" Show_id="false" objectName="Push-2" itemtype="Push" id="Push-2" rotation="0"/>

Connector-5:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Resistor-3-lPin" labelx="-16" objectName="Connector-5" labely="-24" y="-148" endpinid="Arduino Uno-4-GND0" enodeid="Circ_eNode-6" labelrot="0" pointList="-220,-148,-220,-108,-140,-108" rotation="0" id="Connector-5" valLabelx="0" valLabRot="0" x="-220"/>

Connector-11:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-rnod" labelx="-16" objectName="Connector-11" labely="-24" y="-308" endpinid="Arduino Uno-4-V5V" enodeid="Circ_eNode-12" labelrot="0" pointList="-84,-308,44,-308,44,-148,4,-148" rotation="0" id="Connector-11" valLabelx="0" valLabRot="0" x="-84"/>

Connector-9:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-lnod" labelx="-16" objectName="Connector-9" labely="-24" y="-308" endpinid="Node-16-0" enodeid="enode-15" labelrot="0" pointList="-116,-308,-220,-308,-220,-204" rotation="0" id="Connector-9" valLabelx="0" valLabRot="0" x="-116"/>

Connector-15:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Arduino Uno-4-PD7" labelx="-16" objectName="Connector-15" labely="-24" y="-172" endpinid="Node-16-1" enodeid="enode-15" labelrot="0" pointList="-140,-172,-172,-172,-172,-204,-220,-204" rotation="0" id="Connector-15" valLabelx="0" valLabRot="0" x="-140"/>

Connector-17:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Node-16-2" labelx="-16" objectName="Connector-17" labely="-24" y="-204" endpinid="Resistor-3-rPin" enodeid="enode-15" labelrot="0" pointList="-220,-204,-220,-180" rotation="0" id="Connector-17" valLabelx="0" valLabRot="0" x="-220"/>

PlotterWidget-13:
<item modal="false" childrenRect="" normalGeometry="" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="200" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="200" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="200" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" MinVolt="-500" fullScreen="false" windowTitle="" windowIcon="" maximumWidth="1000" objectName="PlotterWidget-13" toolTip="" toolTipDuration="-1" focus="false" MaxVolt="500" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="200" minimumHeight="200" size="" focusPolicy="0" itemtype="Plotter" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

SerialPortWidget-14:
<item modal="false" childrenRect="" normalGeometry="" SettingsProp="COM1,0,3,0,0,0" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="170" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="141" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="313" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" fullScreen="false" windowTitle="Settings" windowIcon="" maximumWidth="450" objectName="SerialPortWidget-14" toolTip="" toolTipDuration="-1" focus="false" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="0" minimumHeight="0" size="" focusPolicy="0" itemtype="SerialPort" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

</circuit>




and I expect the LED to be turned on-off everytime I push the button, however the result is unstable:






I would appreciate if you could help me know if there is something wrong with my code or circuit and I should expect the same behavior on an actual hardware, or this is a simulation issue?



P.S.1. All file can also be downloaded from here.



P.S.2. I'm using this example from Arduino.org website.



P.S.3. I also tried using an actual Arduino, also implementing the suggestions below. However the issue is not resolved. You may see the video here.










share|improve this question
























  • You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

    – Jot
    Apr 10 at 14:48















1















I am trying to run this code:



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT);


void loop()

buttonState = digitalRead(buttonPin);


if (buttonState = HIGH && lastButtonState != buttonState)
flag = !flag;
if (flag)
digitalWrite(ledPin13, LOW);
else
digitalWrite(ledPin13, HIGH);





on this SimulIDE model:





<circuit reactStep="50" animate="0" type="simulide_0.1" noLinStep="10" noLinAcc="5" speed="1000000">

Node-16:
<item labelrot="0" y="-204" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-220" labelx="-16" labely="-24" Show_id="false" objectName="Node-16" itemtype="Node" id="Node-16" rotation="0"/>

Arduino Uno-4:
<item hflip="1" Show_id="true" valLabely="0" itemtype="Arduino" vflip="1" labelx="0" objectName="Arduino Uno-4" labely="-20" y="-244" Ser_Port="false" labelrot="0" rotation="0" Program="../../Google Drive/Active projects/SRL/Students/Damian2019/Simulation/20190409/noDelay_20190409/noDelay_20190409.ino.standard.hex" Ser_Monitor="false" id="Arduino Uno-4" valLabelx="0" Mhz="16" valLabRot="0" x="-148"/>

Resistor-3:
<item Unit=" O" hflip="1" Show_id="false" valLabely="6" itemtype="Resistor" Show_res="true" vflip="1" labelx="-12" objectName="Resistor-3" labely="-24" y="-164" labelrot="0" rotation="-90" Resistance="100" id="Resistor-3" valLabelx="-16" valLabRot="0" x="-220"/>

Push-2:
<item labelrot="0" y="-308" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-100" labelx="-16" labely="-24" Show_id="false" objectName="Push-2" itemtype="Push" id="Push-2" rotation="0"/>

Connector-5:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Resistor-3-lPin" labelx="-16" objectName="Connector-5" labely="-24" y="-148" endpinid="Arduino Uno-4-GND0" enodeid="Circ_eNode-6" labelrot="0" pointList="-220,-148,-220,-108,-140,-108" rotation="0" id="Connector-5" valLabelx="0" valLabRot="0" x="-220"/>

Connector-11:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-rnod" labelx="-16" objectName="Connector-11" labely="-24" y="-308" endpinid="Arduino Uno-4-V5V" enodeid="Circ_eNode-12" labelrot="0" pointList="-84,-308,44,-308,44,-148,4,-148" rotation="0" id="Connector-11" valLabelx="0" valLabRot="0" x="-84"/>

Connector-9:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-lnod" labelx="-16" objectName="Connector-9" labely="-24" y="-308" endpinid="Node-16-0" enodeid="enode-15" labelrot="0" pointList="-116,-308,-220,-308,-220,-204" rotation="0" id="Connector-9" valLabelx="0" valLabRot="0" x="-116"/>

Connector-15:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Arduino Uno-4-PD7" labelx="-16" objectName="Connector-15" labely="-24" y="-172" endpinid="Node-16-1" enodeid="enode-15" labelrot="0" pointList="-140,-172,-172,-172,-172,-204,-220,-204" rotation="0" id="Connector-15" valLabelx="0" valLabRot="0" x="-140"/>

Connector-17:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Node-16-2" labelx="-16" objectName="Connector-17" labely="-24" y="-204" endpinid="Resistor-3-rPin" enodeid="enode-15" labelrot="0" pointList="-220,-204,-220,-180" rotation="0" id="Connector-17" valLabelx="0" valLabRot="0" x="-220"/>

PlotterWidget-13:
<item modal="false" childrenRect="" normalGeometry="" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="200" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="200" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="200" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" MinVolt="-500" fullScreen="false" windowTitle="" windowIcon="" maximumWidth="1000" objectName="PlotterWidget-13" toolTip="" toolTipDuration="-1" focus="false" MaxVolt="500" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="200" minimumHeight="200" size="" focusPolicy="0" itemtype="Plotter" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

SerialPortWidget-14:
<item modal="false" childrenRect="" normalGeometry="" SettingsProp="COM1,0,3,0,0,0" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="170" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="141" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="313" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" fullScreen="false" windowTitle="Settings" windowIcon="" maximumWidth="450" objectName="SerialPortWidget-14" toolTip="" toolTipDuration="-1" focus="false" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="0" minimumHeight="0" size="" focusPolicy="0" itemtype="SerialPort" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

</circuit>




and I expect the LED to be turned on-off everytime I push the button, however the result is unstable:






I would appreciate if you could help me know if there is something wrong with my code or circuit and I should expect the same behavior on an actual hardware, or this is a simulation issue?



P.S.1. All file can also be downloaded from here.



P.S.2. I'm using this example from Arduino.org website.



P.S.3. I also tried using an actual Arduino, also implementing the suggestions below. However the issue is not resolved. You may see the video here.










share|improve this question
























  • You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

    – Jot
    Apr 10 at 14:48













1












1








1








I am trying to run this code:



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT);


void loop()

buttonState = digitalRead(buttonPin);


if (buttonState = HIGH && lastButtonState != buttonState)
flag = !flag;
if (flag)
digitalWrite(ledPin13, LOW);
else
digitalWrite(ledPin13, HIGH);





on this SimulIDE model:





<circuit reactStep="50" animate="0" type="simulide_0.1" noLinStep="10" noLinAcc="5" speed="1000000">

Node-16:
<item labelrot="0" y="-204" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-220" labelx="-16" labely="-24" Show_id="false" objectName="Node-16" itemtype="Node" id="Node-16" rotation="0"/>

Arduino Uno-4:
<item hflip="1" Show_id="true" valLabely="0" itemtype="Arduino" vflip="1" labelx="0" objectName="Arduino Uno-4" labely="-20" y="-244" Ser_Port="false" labelrot="0" rotation="0" Program="../../Google Drive/Active projects/SRL/Students/Damian2019/Simulation/20190409/noDelay_20190409/noDelay_20190409.ino.standard.hex" Ser_Monitor="false" id="Arduino Uno-4" valLabelx="0" Mhz="16" valLabRot="0" x="-148"/>

Resistor-3:
<item Unit=" O" hflip="1" Show_id="false" valLabely="6" itemtype="Resistor" Show_res="true" vflip="1" labelx="-12" objectName="Resistor-3" labely="-24" y="-164" labelrot="0" rotation="-90" Resistance="100" id="Resistor-3" valLabelx="-16" valLabRot="0" x="-220"/>

Push-2:
<item labelrot="0" y="-308" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-100" labelx="-16" labely="-24" Show_id="false" objectName="Push-2" itemtype="Push" id="Push-2" rotation="0"/>

Connector-5:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Resistor-3-lPin" labelx="-16" objectName="Connector-5" labely="-24" y="-148" endpinid="Arduino Uno-4-GND0" enodeid="Circ_eNode-6" labelrot="0" pointList="-220,-148,-220,-108,-140,-108" rotation="0" id="Connector-5" valLabelx="0" valLabRot="0" x="-220"/>

Connector-11:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-rnod" labelx="-16" objectName="Connector-11" labely="-24" y="-308" endpinid="Arduino Uno-4-V5V" enodeid="Circ_eNode-12" labelrot="0" pointList="-84,-308,44,-308,44,-148,4,-148" rotation="0" id="Connector-11" valLabelx="0" valLabRot="0" x="-84"/>

Connector-9:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-lnod" labelx="-16" objectName="Connector-9" labely="-24" y="-308" endpinid="Node-16-0" enodeid="enode-15" labelrot="0" pointList="-116,-308,-220,-308,-220,-204" rotation="0" id="Connector-9" valLabelx="0" valLabRot="0" x="-116"/>

Connector-15:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Arduino Uno-4-PD7" labelx="-16" objectName="Connector-15" labely="-24" y="-172" endpinid="Node-16-1" enodeid="enode-15" labelrot="0" pointList="-140,-172,-172,-172,-172,-204,-220,-204" rotation="0" id="Connector-15" valLabelx="0" valLabRot="0" x="-140"/>

Connector-17:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Node-16-2" labelx="-16" objectName="Connector-17" labely="-24" y="-204" endpinid="Resistor-3-rPin" enodeid="enode-15" labelrot="0" pointList="-220,-204,-220,-180" rotation="0" id="Connector-17" valLabelx="0" valLabRot="0" x="-220"/>

PlotterWidget-13:
<item modal="false" childrenRect="" normalGeometry="" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="200" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="200" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="200" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" MinVolt="-500" fullScreen="false" windowTitle="" windowIcon="" maximumWidth="1000" objectName="PlotterWidget-13" toolTip="" toolTipDuration="-1" focus="false" MaxVolt="500" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="200" minimumHeight="200" size="" focusPolicy="0" itemtype="Plotter" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

SerialPortWidget-14:
<item modal="false" childrenRect="" normalGeometry="" SettingsProp="COM1,0,3,0,0,0" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="170" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="141" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="313" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" fullScreen="false" windowTitle="Settings" windowIcon="" maximumWidth="450" objectName="SerialPortWidget-14" toolTip="" toolTipDuration="-1" focus="false" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="0" minimumHeight="0" size="" focusPolicy="0" itemtype="SerialPort" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

</circuit>




and I expect the LED to be turned on-off everytime I push the button, however the result is unstable:






I would appreciate if you could help me know if there is something wrong with my code or circuit and I should expect the same behavior on an actual hardware, or this is a simulation issue?



P.S.1. All file can also be downloaded from here.



P.S.2. I'm using this example from Arduino.org website.



P.S.3. I also tried using an actual Arduino, also implementing the suggestions below. However the issue is not resolved. You may see the video here.










share|improve this question
















I am trying to run this code:



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT);


void loop()

buttonState = digitalRead(buttonPin);


if (buttonState = HIGH && lastButtonState != buttonState)
flag = !flag;
if (flag)
digitalWrite(ledPin13, LOW);
else
digitalWrite(ledPin13, HIGH);





on this SimulIDE model:





<circuit reactStep="50" animate="0" type="simulide_0.1" noLinStep="10" noLinAcc="5" speed="1000000">

Node-16:
<item labelrot="0" y="-204" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-220" labelx="-16" labely="-24" Show_id="false" objectName="Node-16" itemtype="Node" id="Node-16" rotation="0"/>

Arduino Uno-4:
<item hflip="1" Show_id="true" valLabely="0" itemtype="Arduino" vflip="1" labelx="0" objectName="Arduino Uno-4" labely="-20" y="-244" Ser_Port="false" labelrot="0" rotation="0" Program="../../Google Drive/Active projects/SRL/Students/Damian2019/Simulation/20190409/noDelay_20190409/noDelay_20190409.ino.standard.hex" Ser_Monitor="false" id="Arduino Uno-4" valLabelx="0" Mhz="16" valLabRot="0" x="-148"/>

Resistor-3:
<item Unit=" O" hflip="1" Show_id="false" valLabely="6" itemtype="Resistor" Show_res="true" vflip="1" labelx="-12" objectName="Resistor-3" labely="-24" y="-164" labelrot="0" rotation="-90" Resistance="100" id="Resistor-3" valLabelx="-16" valLabRot="0" x="-220"/>

Push-2:
<item labelrot="0" y="-308" valLabRot="0" valLabelx="0" valLabely="0" hflip="1" vflip="1" x="-100" labelx="-16" labely="-24" Show_id="false" objectName="Push-2" itemtype="Push" id="Push-2" rotation="0"/>

Connector-5:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Resistor-3-lPin" labelx="-16" objectName="Connector-5" labely="-24" y="-148" endpinid="Arduino Uno-4-GND0" enodeid="Circ_eNode-6" labelrot="0" pointList="-220,-148,-220,-108,-140,-108" rotation="0" id="Connector-5" valLabelx="0" valLabRot="0" x="-220"/>

Connector-11:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-rnod" labelx="-16" objectName="Connector-11" labely="-24" y="-308" endpinid="Arduino Uno-4-V5V" enodeid="Circ_eNode-12" labelrot="0" pointList="-84,-308,44,-308,44,-148,4,-148" rotation="0" id="Connector-11" valLabelx="0" valLabRot="0" x="-84"/>

Connector-9:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Push-2-lnod" labelx="-16" objectName="Connector-9" labely="-24" y="-308" endpinid="Node-16-0" enodeid="enode-15" labelrot="0" pointList="-116,-308,-220,-308,-220,-204" rotation="0" id="Connector-9" valLabelx="0" valLabRot="0" x="-116"/>

Connector-15:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Arduino Uno-4-PD7" labelx="-16" objectName="Connector-15" labely="-24" y="-172" endpinid="Node-16-1" enodeid="enode-15" labelrot="0" pointList="-140,-172,-172,-172,-172,-204,-220,-204" rotation="0" id="Connector-15" valLabelx="0" valLabRot="0" x="-140"/>

Connector-17:
<item hflip="1" Show_id="false" valLabely="0" itemtype="Connector" vflip="1" startpinid="Node-16-2" labelx="-16" objectName="Connector-17" labely="-24" y="-204" endpinid="Resistor-3-rPin" enodeid="enode-15" labelrot="0" pointList="-220,-204,-220,-180" rotation="0" id="Connector-17" valLabelx="0" valLabRot="0" x="-220"/>

PlotterWidget-13:
<item modal="false" childrenRect="" normalGeometry="" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="200" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="200" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="200" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" MinVolt="-500" fullScreen="false" windowTitle="" windowIcon="" maximumWidth="1000" objectName="PlotterWidget-13" toolTip="" toolTipDuration="-1" focus="false" MaxVolt="500" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="200" minimumHeight="200" size="" focusPolicy="0" itemtype="Plotter" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

SerialPortWidget-14:
<item modal="false" childrenRect="" normalGeometry="" SettingsProp="COM1,0,3,0,0,0" baseSize="" geometry="" sizeIncrement="" windowOpacity="1" windowModified="false" enabled="true" maximumSize="" childrenRegion="" maximumHeight="170" inputMethodHints="0" mouseTracking="false" minimumSize="" frameGeometry="" sizeHint="" windowIconText="" locale="" minimumSizeHint="" height="141" isActiveWindow="true" x="0" accessibleName="" layoutDirection="0" autoFillBackground="false" width="313" windowFilePath="" windowModality="0" maximized="false" sizePolicy="" fullScreen="false" windowTitle="Settings" windowIcon="" maximumWidth="450" objectName="SerialPortWidget-14" toolTip="" toolTipDuration="-1" focus="false" palette="" font="MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0" whatsThis="" pos="" minimumWidth="0" minimumHeight="0" size="" focusPolicy="0" itemtype="SerialPort" updatesEnabled="true" accessibleDescription="" y="0" rect="" frameSize="" minimized="false" acceptDrops="false" styleSheet="" cursor="" visible="false" statusTip="" contextMenuPolicy="1"/>

</circuit>




and I expect the LED to be turned on-off everytime I push the button, however the result is unstable:






I would appreciate if you could help me know if there is something wrong with my code or circuit and I should expect the same behavior on an actual hardware, or this is a simulation issue?



P.S.1. All file can also be downloaded from here.



P.S.2. I'm using this example from Arduino.org website.



P.S.3. I also tried using an actual Arduino, also implementing the suggestions below. However the issue is not resolved. You may see the video here.







arduino-uno led button






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Apr 10 at 12:22







Foad

















asked Apr 10 at 11:23









FoadFoad

1185




1185












  • You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

    – Jot
    Apr 10 at 14:48

















  • You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

    – Jot
    Apr 10 at 14:48
















You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

– Jot
Apr 10 at 14:48





You need the state-change-detection: arduino.cc/en/Tutorial/StateChangeDetection

– Jot
Apr 10 at 14:48










4 Answers
4






active

oldest

votes


















2














Certain Changes in your code:



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT);


void loop()

buttonState = digitalRead(buttonPin);


if (buttonState == HIGH && lastButtonState != buttonState)
lastButtonState = buttonState;
flag =!flag;
if (flag)
digitalWrite(ledPin13, LOW);
else
digitalWrite(ledPin13, HIGH);





Secondly your hardware model is not good.
ANODE of LED must be connected to PIN13 and Cathode to GND. And switch must be placed between 3.3 V and Pin7 only.
In your model by closing switch you are shorting 3.3V and GND. If you had provided an external pullup then you should use at minimum a 4.7K resistor value. 100ohm never works.



I don't have software for Design so I used Paint and made a sketch for you.





schematic





simulate this circuit – Schematic created using CircuitLab






share|improve this answer

























  • ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

    – Foad
    Apr 10 at 11:38











  • The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

    – Duncan C
    Apr 10 at 13:40











  • In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

    – Duncan C
    Apr 10 at 13:41






  • 2





    There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

    – orithena
    Apr 10 at 13:44


















2














I identify a few problems here:



  • The 100 Ohm pulldown resistor for the button is way too low. 1 kOhm to 100 kOhm is typically used here.


  • if( buttonState = HIGH ) does not compare, it assigns buttonState to HIGH (overwriting the value read with digitalRead(buttonPin)). Use the compare-for-equality operator == here, otherwise the if just checks if buttonState has been assigned a "truthlike" value (incidentally, HIGH is one of them).

  • As others have already commented, lastButtonState must be set somewhere after the if-block!

Since many Arduinos do have pullup resistors built in, I'd say: drop the resistor completely, instead initialize the button input pin (7) to use its built-in pullup resistor ... this will invert the logic and you'll have to connect the button between pin 7 and GND (i.e. swapping button and resistor), though:



 pinMode(buttonPin, INPUT_PULLUP);


This will have the same result as if you replaced the 100 Ohm resistor with a 20 kOhm resistor after swapping button and resistor -- but that resistor is now inside the Arduino. (Take care if you use "Arduino-compatible" boards; sometimes they lack the pullup resistors or have them fixed!).



There still is one problem: bouncing. Pressing a mechanical button leads to the contacts inside the button to bounce a bit against each other, leading to a very fast HIGH-LOW-HIGH-LOW-etc signal before it settles on the target state. You can alleviate this a bit by adding a delay(5) at the end of your loop(), but using a button library (e.g. Button, available in the Arduino IDE Library Manager) that debounces the signal will lead to better results most of the time.



This will lead to this code (also including the ternary operator hint by Michel Keijzers):



const int buttonPin = 7; 
const int ledPin13 = 13;

int buttonState = 0;
int lastButtonState = buttonState;
bool flag = true;

void setup()
// initialize the LED pin as an output:
pinMode(ledPin13, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin, INPUT_PULLUP);


void loop()
buttonState = digitalRead(buttonPin);

if (buttonState == LOW && lastButtonState != buttonState)
flag = !flag;
digitalWrite(ledPin13, flag ? LOW : HIGH);


lastButtonState = buttonState;
delay(5);



This should do the trick (I didn't try it, though).






share|improve this answer

























  • OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

    – Foad
    Apr 10 at 15:05











  • ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

    – Foad
    Apr 10 at 15:15






  • 1





    @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

    – orithena
    Apr 10 at 15:16












  • could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

    – Foad
    Apr 11 at 7:57











  • @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

    – orithena
    Apr 11 at 11:01


















1














There are already great answers, but I also found out about the interrupt functionality:



const byte ledPin = 13;
const byte interruptPin = 2;
volatile byte state = LOW;

void setup()
pinMode(ledPin, OUTPUT);
pinMode(interruptPin, INPUT_PULLUP);
attachInterrupt(digitalPinToInterrupt(interruptPin), blink, FALLING);


void loop()
digitalWrite(ledPin, state);


void blink()
state = !state;



some point:



  • no matter using interrupt or the methods above tho process will not achieve stable / deterministic result. The issue lies in the hardware of the push-button and there will be fluctuations which can be interpreted by the MCU. One way to alleviate is to use delay.

  • The


  • attachInterrupt has four modes LOW, Change, FALLING and RISING. The FALLING and RISING modes are the one to be used. the other two also lead to very unpredictable result.

  • Only pins 1 and 2 can be used for interrupts.

  • There is also the option to mix the two methods which you can see here, but I'm not sure if it will improve the stability.

I used this video and information on this page.






share|improve this answer
































    0














    This is a comment (but could not use text alignment in a comment):



    Instead of



    if (flag)
    digitalWrite(ledPin13, LOW);
    else
    digitalWrite(ledPin13, HIGH);



    You can use:



    digitalWrite(ledPin13, flag ? LOW : HIGH);


    (It is functionally 100% equal though).






    share|improve this answer


















    • 1





      Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

      – Michel Keijzers
      Apr 10 at 11:58






    • 1





      Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

      – Michel Keijzers
      Apr 10 at 12:00






    • 1





      I do not understand why they down voted you. I appreciate your support anyway.

      – Foad
      Apr 10 at 20:32






    • 1





      Probably because it should be a comment (but code alignment is only possible inside an answer).

      – Michel Keijzers
      Apr 10 at 20:40







    • 1





      @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

      – orithena
      Apr 11 at 11:13











    Your Answer






    StackExchange.ifUsing("editor", function ()
    return StackExchange.using("schematics", function ()
    StackExchange.schematics.init();
    );
    , "cicuitlab");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "540"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: false,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2farduino.stackexchange.com%2fquestions%2f63343%2fchanging-state-of-an-led-using-a-pushbutton-leads-to-unstable-result%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    4 Answers
    4






    active

    oldest

    votes








    4 Answers
    4






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2














    Certain Changes in your code:



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT);


    void loop()

    buttonState = digitalRead(buttonPin);


    if (buttonState == HIGH && lastButtonState != buttonState)
    lastButtonState = buttonState;
    flag =!flag;
    if (flag)
    digitalWrite(ledPin13, LOW);
    else
    digitalWrite(ledPin13, HIGH);





    Secondly your hardware model is not good.
    ANODE of LED must be connected to PIN13 and Cathode to GND. And switch must be placed between 3.3 V and Pin7 only.
    In your model by closing switch you are shorting 3.3V and GND. If you had provided an external pullup then you should use at minimum a 4.7K resistor value. 100ohm never works.



    I don't have software for Design so I used Paint and made a sketch for you.





    schematic





    simulate this circuit – Schematic created using CircuitLab






    share|improve this answer

























    • ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

      – Foad
      Apr 10 at 11:38











    • The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

      – Duncan C
      Apr 10 at 13:40











    • In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

      – Duncan C
      Apr 10 at 13:41






    • 2





      There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

      – orithena
      Apr 10 at 13:44















    2














    Certain Changes in your code:



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT);


    void loop()

    buttonState = digitalRead(buttonPin);


    if (buttonState == HIGH && lastButtonState != buttonState)
    lastButtonState = buttonState;
    flag =!flag;
    if (flag)
    digitalWrite(ledPin13, LOW);
    else
    digitalWrite(ledPin13, HIGH);





    Secondly your hardware model is not good.
    ANODE of LED must be connected to PIN13 and Cathode to GND. And switch must be placed between 3.3 V and Pin7 only.
    In your model by closing switch you are shorting 3.3V and GND. If you had provided an external pullup then you should use at minimum a 4.7K resistor value. 100ohm never works.



    I don't have software for Design so I used Paint and made a sketch for you.





    schematic





    simulate this circuit – Schematic created using CircuitLab






    share|improve this answer

























    • ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

      – Foad
      Apr 10 at 11:38











    • The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

      – Duncan C
      Apr 10 at 13:40











    • In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

      – Duncan C
      Apr 10 at 13:41






    • 2





      There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

      – orithena
      Apr 10 at 13:44













    2












    2








    2







    Certain Changes in your code:



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT);


    void loop()

    buttonState = digitalRead(buttonPin);


    if (buttonState == HIGH && lastButtonState != buttonState)
    lastButtonState = buttonState;
    flag =!flag;
    if (flag)
    digitalWrite(ledPin13, LOW);
    else
    digitalWrite(ledPin13, HIGH);





    Secondly your hardware model is not good.
    ANODE of LED must be connected to PIN13 and Cathode to GND. And switch must be placed between 3.3 V and Pin7 only.
    In your model by closing switch you are shorting 3.3V and GND. If you had provided an external pullup then you should use at minimum a 4.7K resistor value. 100ohm never works.



    I don't have software for Design so I used Paint and made a sketch for you.





    schematic





    simulate this circuit – Schematic created using CircuitLab






    share|improve this answer















    Certain Changes in your code:



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT);


    void loop()

    buttonState = digitalRead(buttonPin);


    if (buttonState == HIGH && lastButtonState != buttonState)
    lastButtonState = buttonState;
    flag =!flag;
    if (flag)
    digitalWrite(ledPin13, LOW);
    else
    digitalWrite(ledPin13, HIGH);





    Secondly your hardware model is not good.
    ANODE of LED must be connected to PIN13 and Cathode to GND. And switch must be placed between 3.3 V and Pin7 only.
    In your model by closing switch you are shorting 3.3V and GND. If you had provided an external pullup then you should use at minimum a 4.7K resistor value. 100ohm never works.



    I don't have software for Design so I used Paint and made a sketch for you.





    schematic





    simulate this circuit – Schematic created using CircuitLab







    share|improve this answer














    share|improve this answer



    share|improve this answer








    edited Apr 10 at 23:55









    Foad

    1185




    1185










    answered Apr 10 at 11:33









    VaibhavVaibhav

    1124




    1124












    • ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

      – Foad
      Apr 10 at 11:38











    • The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

      – Duncan C
      Apr 10 at 13:40











    • In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

      – Duncan C
      Apr 10 at 13:41






    • 2





      There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

      – orithena
      Apr 10 at 13:44

















    • ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

      – Foad
      Apr 10 at 11:38











    • The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

      – Duncan C
      Apr 10 at 13:40











    • In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

      – Duncan C
      Apr 10 at 13:41






    • 2





      There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

      – orithena
      Apr 10 at 13:44
















    ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

    – Foad
    Apr 10 at 11:38





    ah my bad the lastButtonState = buttonState; was in the actual code but I dropped it accidentally in the example. would you be kind to draw the correct circuit? I'm not sure if I understand exactly what you mean.

    – Foad
    Apr 10 at 11:38













    The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

    – Duncan C
    Apr 10 at 13:40





    The OP is using 5V, not 3.3v. And how is his circuit's switch shorting 3.3V/5V to ground? If pin7 were an output, and LOW, it would be a low resistance path to ground. It might be a good idea to put a 1K resistor on Pin7.

    – Duncan C
    Apr 10 at 13:40













    In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

    – Duncan C
    Apr 10 at 13:41





    In your diagram, you need a current-limiting resistor on the LED or it will both draw too much current from pin13 and over-drive the LED (But I think the OP is using the built-in LED on pin 13 rather than adding an external LED.)

    – Duncan C
    Apr 10 at 13:41




    2




    2





    There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

    – orithena
    Apr 10 at 13:44





    There's still a problem in the code: lastButtonState will always be HIGH, because it is inside the if(buttonState == HIGH) block.

    – orithena
    Apr 10 at 13:44











    2














    I identify a few problems here:



    • The 100 Ohm pulldown resistor for the button is way too low. 1 kOhm to 100 kOhm is typically used here.


    • if( buttonState = HIGH ) does not compare, it assigns buttonState to HIGH (overwriting the value read with digitalRead(buttonPin)). Use the compare-for-equality operator == here, otherwise the if just checks if buttonState has been assigned a "truthlike" value (incidentally, HIGH is one of them).

    • As others have already commented, lastButtonState must be set somewhere after the if-block!

    Since many Arduinos do have pullup resistors built in, I'd say: drop the resistor completely, instead initialize the button input pin (7) to use its built-in pullup resistor ... this will invert the logic and you'll have to connect the button between pin 7 and GND (i.e. swapping button and resistor), though:



     pinMode(buttonPin, INPUT_PULLUP);


    This will have the same result as if you replaced the 100 Ohm resistor with a 20 kOhm resistor after swapping button and resistor -- but that resistor is now inside the Arduino. (Take care if you use "Arduino-compatible" boards; sometimes they lack the pullup resistors or have them fixed!).



    There still is one problem: bouncing. Pressing a mechanical button leads to the contacts inside the button to bounce a bit against each other, leading to a very fast HIGH-LOW-HIGH-LOW-etc signal before it settles on the target state. You can alleviate this a bit by adding a delay(5) at the end of your loop(), but using a button library (e.g. Button, available in the Arduino IDE Library Manager) that debounces the signal will lead to better results most of the time.



    This will lead to this code (also including the ternary operator hint by Michel Keijzers):



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT_PULLUP);


    void loop()
    buttonState = digitalRead(buttonPin);

    if (buttonState == LOW && lastButtonState != buttonState)
    flag = !flag;
    digitalWrite(ledPin13, flag ? LOW : HIGH);


    lastButtonState = buttonState;
    delay(5);



    This should do the trick (I didn't try it, though).






    share|improve this answer

























    • OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

      – Foad
      Apr 10 at 15:05











    • ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

      – Foad
      Apr 10 at 15:15






    • 1





      @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

      – orithena
      Apr 10 at 15:16












    • could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

      – Foad
      Apr 11 at 7:57











    • @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

      – orithena
      Apr 11 at 11:01















    2














    I identify a few problems here:



    • The 100 Ohm pulldown resistor for the button is way too low. 1 kOhm to 100 kOhm is typically used here.


    • if( buttonState = HIGH ) does not compare, it assigns buttonState to HIGH (overwriting the value read with digitalRead(buttonPin)). Use the compare-for-equality operator == here, otherwise the if just checks if buttonState has been assigned a "truthlike" value (incidentally, HIGH is one of them).

    • As others have already commented, lastButtonState must be set somewhere after the if-block!

    Since many Arduinos do have pullup resistors built in, I'd say: drop the resistor completely, instead initialize the button input pin (7) to use its built-in pullup resistor ... this will invert the logic and you'll have to connect the button between pin 7 and GND (i.e. swapping button and resistor), though:



     pinMode(buttonPin, INPUT_PULLUP);


    This will have the same result as if you replaced the 100 Ohm resistor with a 20 kOhm resistor after swapping button and resistor -- but that resistor is now inside the Arduino. (Take care if you use "Arduino-compatible" boards; sometimes they lack the pullup resistors or have them fixed!).



    There still is one problem: bouncing. Pressing a mechanical button leads to the contacts inside the button to bounce a bit against each other, leading to a very fast HIGH-LOW-HIGH-LOW-etc signal before it settles on the target state. You can alleviate this a bit by adding a delay(5) at the end of your loop(), but using a button library (e.g. Button, available in the Arduino IDE Library Manager) that debounces the signal will lead to better results most of the time.



    This will lead to this code (also including the ternary operator hint by Michel Keijzers):



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT_PULLUP);


    void loop()
    buttonState = digitalRead(buttonPin);

    if (buttonState == LOW && lastButtonState != buttonState)
    flag = !flag;
    digitalWrite(ledPin13, flag ? LOW : HIGH);


    lastButtonState = buttonState;
    delay(5);



    This should do the trick (I didn't try it, though).






    share|improve this answer

























    • OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

      – Foad
      Apr 10 at 15:05











    • ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

      – Foad
      Apr 10 at 15:15






    • 1





      @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

      – orithena
      Apr 10 at 15:16












    • could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

      – Foad
      Apr 11 at 7:57











    • @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

      – orithena
      Apr 11 at 11:01













    2












    2








    2







    I identify a few problems here:



    • The 100 Ohm pulldown resistor for the button is way too low. 1 kOhm to 100 kOhm is typically used here.


    • if( buttonState = HIGH ) does not compare, it assigns buttonState to HIGH (overwriting the value read with digitalRead(buttonPin)). Use the compare-for-equality operator == here, otherwise the if just checks if buttonState has been assigned a "truthlike" value (incidentally, HIGH is one of them).

    • As others have already commented, lastButtonState must be set somewhere after the if-block!

    Since many Arduinos do have pullup resistors built in, I'd say: drop the resistor completely, instead initialize the button input pin (7) to use its built-in pullup resistor ... this will invert the logic and you'll have to connect the button between pin 7 and GND (i.e. swapping button and resistor), though:



     pinMode(buttonPin, INPUT_PULLUP);


    This will have the same result as if you replaced the 100 Ohm resistor with a 20 kOhm resistor after swapping button and resistor -- but that resistor is now inside the Arduino. (Take care if you use "Arduino-compatible" boards; sometimes they lack the pullup resistors or have them fixed!).



    There still is one problem: bouncing. Pressing a mechanical button leads to the contacts inside the button to bounce a bit against each other, leading to a very fast HIGH-LOW-HIGH-LOW-etc signal before it settles on the target state. You can alleviate this a bit by adding a delay(5) at the end of your loop(), but using a button library (e.g. Button, available in the Arduino IDE Library Manager) that debounces the signal will lead to better results most of the time.



    This will lead to this code (also including the ternary operator hint by Michel Keijzers):



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT_PULLUP);


    void loop()
    buttonState = digitalRead(buttonPin);

    if (buttonState == LOW && lastButtonState != buttonState)
    flag = !flag;
    digitalWrite(ledPin13, flag ? LOW : HIGH);


    lastButtonState = buttonState;
    delay(5);



    This should do the trick (I didn't try it, though).






    share|improve this answer















    I identify a few problems here:



    • The 100 Ohm pulldown resistor for the button is way too low. 1 kOhm to 100 kOhm is typically used here.


    • if( buttonState = HIGH ) does not compare, it assigns buttonState to HIGH (overwriting the value read with digitalRead(buttonPin)). Use the compare-for-equality operator == here, otherwise the if just checks if buttonState has been assigned a "truthlike" value (incidentally, HIGH is one of them).

    • As others have already commented, lastButtonState must be set somewhere after the if-block!

    Since many Arduinos do have pullup resistors built in, I'd say: drop the resistor completely, instead initialize the button input pin (7) to use its built-in pullup resistor ... this will invert the logic and you'll have to connect the button between pin 7 and GND (i.e. swapping button and resistor), though:



     pinMode(buttonPin, INPUT_PULLUP);


    This will have the same result as if you replaced the 100 Ohm resistor with a 20 kOhm resistor after swapping button and resistor -- but that resistor is now inside the Arduino. (Take care if you use "Arduino-compatible" boards; sometimes they lack the pullup resistors or have them fixed!).



    There still is one problem: bouncing. Pressing a mechanical button leads to the contacts inside the button to bounce a bit against each other, leading to a very fast HIGH-LOW-HIGH-LOW-etc signal before it settles on the target state. You can alleviate this a bit by adding a delay(5) at the end of your loop(), but using a button library (e.g. Button, available in the Arduino IDE Library Manager) that debounces the signal will lead to better results most of the time.



    This will lead to this code (also including the ternary operator hint by Michel Keijzers):



    const int buttonPin = 7; 
    const int ledPin13 = 13;

    int buttonState = 0;
    int lastButtonState = buttonState;
    bool flag = true;

    void setup()
    // initialize the LED pin as an output:
    pinMode(ledPin13, OUTPUT);
    // initialize the pushbutton pin as an input:
    pinMode(buttonPin, INPUT_PULLUP);


    void loop()
    buttonState = digitalRead(buttonPin);

    if (buttonState == LOW && lastButtonState != buttonState)
    flag = !flag;
    digitalWrite(ledPin13, flag ? LOW : HIGH);


    lastButtonState = buttonState;
    delay(5);



    This should do the trick (I didn't try it, though).







    share|improve this answer














    share|improve this answer



    share|improve this answer








    edited Apr 11 at 10:58

























    answered Apr 10 at 14:10









    orithenaorithena

    1213




    1213












    • OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

      – Foad
      Apr 10 at 15:05











    • ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

      – Foad
      Apr 10 at 15:15






    • 1





      @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

      – orithena
      Apr 10 at 15:16












    • could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

      – Foad
      Apr 11 at 7:57











    • @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

      – orithena
      Apr 11 at 11:01

















    • OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

      – Foad
      Apr 10 at 15:05











    • ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

      – Foad
      Apr 10 at 15:15






    • 1





      @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

      – orithena
      Apr 10 at 15:16












    • could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

      – Foad
      Apr 11 at 7:57











    • @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

      – orithena
      Apr 11 at 11:01
















    OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

    – Foad
    Apr 10 at 15:05





    OMG how could I make such a mistake!!! Thanks for pointing it out. one issue you should consider is that Arduino uno doesn't have INPUT_PULLDOWN. Apparently only Zero has this? I get the error INPUT_PULLDOWN was not declared in this scope

    – Foad
    Apr 10 at 15:05













    ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

    – Foad
    Apr 10 at 15:15





    ok. it seems the pinMode(buttonPin, INPUT_PULLDOWN); is equivalent of pinMode(pin, INPUT); digitalWrite(pin, LOW); and pinMode(buttonPin, INPUT_PULLUP); is pinMode(pin, INPUT); digitalWrite(pin, HIGH); and that syntax doesn't work properly on some versions of Arduino IDE.

    – Foad
    Apr 10 at 15:15




    1




    1





    @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

    – orithena
    Apr 10 at 15:16






    @Foad You're right, according to arduino.cc/en/Tutorial/DigitalPins INPUT_PULLDOWN seems to be rather seldom... but INPUT_PULLUP should work. Using this would invert the logic on the button pin, though. I'll edit to reflect that.

    – orithena
    Apr 10 at 15:16














    could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

    – Foad
    Apr 11 at 7:57





    could you be kind to 1. draw the circuit using the pullup resistor 2. point me a good button library? thanks again.

    – Foad
    Apr 11 at 7:57













    @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

    – orithena
    Apr 11 at 11:01





    @Foad I added a link to the most simple button library with debouncing from the Arduino IDE Library Manager; documentation is on its github page. Drawing the circuit must have to wait until I'm back home.

    – orithena
    Apr 11 at 11:01











    1














    There are already great answers, but I also found out about the interrupt functionality:



    const byte ledPin = 13;
    const byte interruptPin = 2;
    volatile byte state = LOW;

    void setup()
    pinMode(ledPin, OUTPUT);
    pinMode(interruptPin, INPUT_PULLUP);
    attachInterrupt(digitalPinToInterrupt(interruptPin), blink, FALLING);


    void loop()
    digitalWrite(ledPin, state);


    void blink()
    state = !state;



    some point:



    • no matter using interrupt or the methods above tho process will not achieve stable / deterministic result. The issue lies in the hardware of the push-button and there will be fluctuations which can be interpreted by the MCU. One way to alleviate is to use delay.

    • The


    • attachInterrupt has four modes LOW, Change, FALLING and RISING. The FALLING and RISING modes are the one to be used. the other two also lead to very unpredictable result.

    • Only pins 1 and 2 can be used for interrupts.

    • There is also the option to mix the two methods which you can see here, but I'm not sure if it will improve the stability.

    I used this video and information on this page.






    share|improve this answer





























      1














      There are already great answers, but I also found out about the interrupt functionality:



      const byte ledPin = 13;
      const byte interruptPin = 2;
      volatile byte state = LOW;

      void setup()
      pinMode(ledPin, OUTPUT);
      pinMode(interruptPin, INPUT_PULLUP);
      attachInterrupt(digitalPinToInterrupt(interruptPin), blink, FALLING);


      void loop()
      digitalWrite(ledPin, state);


      void blink()
      state = !state;



      some point:



      • no matter using interrupt or the methods above tho process will not achieve stable / deterministic result. The issue lies in the hardware of the push-button and there will be fluctuations which can be interpreted by the MCU. One way to alleviate is to use delay.

      • The


      • attachInterrupt has four modes LOW, Change, FALLING and RISING. The FALLING and RISING modes are the one to be used. the other two also lead to very unpredictable result.

      • Only pins 1 and 2 can be used for interrupts.

      • There is also the option to mix the two methods which you can see here, but I'm not sure if it will improve the stability.

      I used this video and information on this page.






      share|improve this answer



























        1












        1








        1







        There are already great answers, but I also found out about the interrupt functionality:



        const byte ledPin = 13;
        const byte interruptPin = 2;
        volatile byte state = LOW;

        void setup()
        pinMode(ledPin, OUTPUT);
        pinMode(interruptPin, INPUT_PULLUP);
        attachInterrupt(digitalPinToInterrupt(interruptPin), blink, FALLING);


        void loop()
        digitalWrite(ledPin, state);


        void blink()
        state = !state;



        some point:



        • no matter using interrupt or the methods above tho process will not achieve stable / deterministic result. The issue lies in the hardware of the push-button and there will be fluctuations which can be interpreted by the MCU. One way to alleviate is to use delay.

        • The


        • attachInterrupt has four modes LOW, Change, FALLING and RISING. The FALLING and RISING modes are the one to be used. the other two also lead to very unpredictable result.

        • Only pins 1 and 2 can be used for interrupts.

        • There is also the option to mix the two methods which you can see here, but I'm not sure if it will improve the stability.

        I used this video and information on this page.






        share|improve this answer















        There are already great answers, but I also found out about the interrupt functionality:



        const byte ledPin = 13;
        const byte interruptPin = 2;
        volatile byte state = LOW;

        void setup()
        pinMode(ledPin, OUTPUT);
        pinMode(interruptPin, INPUT_PULLUP);
        attachInterrupt(digitalPinToInterrupt(interruptPin), blink, FALLING);


        void loop()
        digitalWrite(ledPin, state);


        void blink()
        state = !state;



        some point:



        • no matter using interrupt or the methods above tho process will not achieve stable / deterministic result. The issue lies in the hardware of the push-button and there will be fluctuations which can be interpreted by the MCU. One way to alleviate is to use delay.

        • The


        • attachInterrupt has four modes LOW, Change, FALLING and RISING. The FALLING and RISING modes are the one to be used. the other two also lead to very unpredictable result.

        • Only pins 1 and 2 can be used for interrupts.

        • There is also the option to mix the two methods which you can see here, but I'm not sure if it will improve the stability.

        I used this video and information on this page.







        share|improve this answer














        share|improve this answer



        share|improve this answer








        edited Apr 10 at 15:47

























        answered Apr 10 at 15:27









        FoadFoad

        1185




        1185





















            0














            This is a comment (but could not use text alignment in a comment):



            Instead of



            if (flag)
            digitalWrite(ledPin13, LOW);
            else
            digitalWrite(ledPin13, HIGH);



            You can use:



            digitalWrite(ledPin13, flag ? LOW : HIGH);


            (It is functionally 100% equal though).






            share|improve this answer


















            • 1





              Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

              – Michel Keijzers
              Apr 10 at 11:58






            • 1





              Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

              – Michel Keijzers
              Apr 10 at 12:00






            • 1





              I do not understand why they down voted you. I appreciate your support anyway.

              – Foad
              Apr 10 at 20:32






            • 1





              Probably because it should be a comment (but code alignment is only possible inside an answer).

              – Michel Keijzers
              Apr 10 at 20:40







            • 1





              @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

              – orithena
              Apr 11 at 11:13















            0














            This is a comment (but could not use text alignment in a comment):



            Instead of



            if (flag)
            digitalWrite(ledPin13, LOW);
            else
            digitalWrite(ledPin13, HIGH);



            You can use:



            digitalWrite(ledPin13, flag ? LOW : HIGH);


            (It is functionally 100% equal though).






            share|improve this answer


















            • 1





              Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

              – Michel Keijzers
              Apr 10 at 11:58






            • 1





              Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

              – Michel Keijzers
              Apr 10 at 12:00






            • 1





              I do not understand why they down voted you. I appreciate your support anyway.

              – Foad
              Apr 10 at 20:32






            • 1





              Probably because it should be a comment (but code alignment is only possible inside an answer).

              – Michel Keijzers
              Apr 10 at 20:40







            • 1





              @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

              – orithena
              Apr 11 at 11:13













            0












            0








            0







            This is a comment (but could not use text alignment in a comment):



            Instead of



            if (flag)
            digitalWrite(ledPin13, LOW);
            else
            digitalWrite(ledPin13, HIGH);



            You can use:



            digitalWrite(ledPin13, flag ? LOW : HIGH);


            (It is functionally 100% equal though).






            share|improve this answer













            This is a comment (but could not use text alignment in a comment):



            Instead of



            if (flag)
            digitalWrite(ledPin13, LOW);
            else
            digitalWrite(ledPin13, HIGH);



            You can use:



            digitalWrite(ledPin13, flag ? LOW : HIGH);


            (It is functionally 100% equal though).







            share|improve this answer












            share|improve this answer



            share|improve this answer










            answered Apr 10 at 11:46









            Michel KeijzersMichel Keijzers

            7,02251939




            7,02251939







            • 1





              Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

              – Michel Keijzers
              Apr 10 at 11:58






            • 1





              Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

              – Michel Keijzers
              Apr 10 at 12:00






            • 1





              I do not understand why they down voted you. I appreciate your support anyway.

              – Foad
              Apr 10 at 20:32






            • 1





              Probably because it should be a comment (but code alignment is only possible inside an answer).

              – Michel Keijzers
              Apr 10 at 20:40







            • 1





              @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

              – orithena
              Apr 11 at 11:13












            • 1





              Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

              – Michel Keijzers
              Apr 10 at 11:58






            • 1





              Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

              – Michel Keijzers
              Apr 10 at 12:00






            • 1





              I do not understand why they down voted you. I appreciate your support anyway.

              – Foad
              Apr 10 at 20:32






            • 1





              Probably because it should be a comment (but code alignment is only possible inside an answer).

              – Michel Keijzers
              Apr 10 at 20:40







            • 1





              @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

              – orithena
              Apr 11 at 11:13







            1




            1





            Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

            – Michel Keijzers
            Apr 10 at 11:58





            Actually the Arduino IDE is very similar to C++. The ternary operator is from the C language.

            – Michel Keijzers
            Apr 10 at 11:58




            1




            1





            Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

            – Michel Keijzers
            Apr 10 at 12:00





            Also several libraries are written in C++ (so you can use OO/classes); however some features are better to skip (like the Boost library if it works at all), because of dynamic memory management versus having only a few KB SRAM available.

            – Michel Keijzers
            Apr 10 at 12:00




            1




            1





            I do not understand why they down voted you. I appreciate your support anyway.

            – Foad
            Apr 10 at 20:32





            I do not understand why they down voted you. I appreciate your support anyway.

            – Foad
            Apr 10 at 20:32




            1




            1





            Probably because it should be a comment (but code alignment is only possible inside an answer).

            – Michel Keijzers
            Apr 10 at 20:40






            Probably because it should be a comment (but code alignment is only possible inside an answer).

            – Michel Keijzers
            Apr 10 at 20:40





            1




            1





            @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

            – orithena
            Apr 11 at 11:13





            @Foad You could think of the Arduino sketch file as a part of a standard C/C++ file. Prior to compiling, the sketch is just inserted into the main file of a standard GCC build tree, included library files and hardware libraries are just copied next to it. Then gcc takes over; you could see its output if you enable verbose compiling in the Arduino IDE preferences.

            – orithena
            Apr 11 at 11:13

















            draft saved

            draft discarded
















































            Thanks for contributing an answer to Arduino Stack Exchange!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2farduino.stackexchange.com%2fquestions%2f63343%2fchanging-state-of-an-led-using-a-pushbutton-leads-to-unstable-result%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            រឿង រ៉ូមេអូ និង ហ្ស៊ុយលីយេ សង្ខេបរឿង តួអង្គ បញ្ជីណែនាំ

            Crop image to path created in TikZ? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Crop an inserted image?TikZ pictures does not appear in posterImage behind and beyond crop marks?Tikz picture as large as possible on A4 PageTransparency vs image compression dilemmaHow to crop background from image automatically?Image does not cropTikzexternal capturing crop marks when externalizing pgfplots?How to include image path that contains a dollar signCrop image with left size given

            Romeo and Juliet ContentsCharactersSynopsisSourcesDate and textThemes and motifsCriticism and interpretationLegacyScene by sceneSee alsoNotes and referencesSourcesExternal linksNavigation menu"Consumer Price Index (estimate) 1800–"10.2307/28710160037-3222287101610.1093/res/II.5.31910.2307/45967845967810.2307/2869925286992510.1525/jams.1982.35.3.03a00050"Dada Masilo: South African dancer who breaks the rules"10.1093/res/os-XV.57.1610.2307/28680942868094"Sweet Sorrow: Mann-Korman's Romeo and Juliet Closes Sept. 5 at MN's Ordway"the original10.2307/45957745957710.1017/CCOL0521570476.009"Ram Leela box office collections hit massive Rs 100 crore, pulverises prediction"Archived"Broadway Revival of Romeo and Juliet, Starring Orlando Bloom and Condola Rashad, Will Close Dec. 8"Archived10.1075/jhp.7.1.04hon"Wherefore art thou, Romeo? To make us laugh at Navy Pier"the original10.1093/gmo/9781561592630.article.O006772"Ram-leela Review Roundup: Critics Hail Film as Best Adaptation of Romeo and Juliet"Archived10.2307/31946310047-77293194631"Romeo and Juliet get Twitter treatment""Juliet's Nurse by Lois Leveen""Romeo and Juliet: Orlando Bloom's Broadway Debut Released in Theaters for Valentine's Day"Archived"Romeo and Juliet Has No Balcony"10.1093/gmo/9781561592630.article.O00778110.2307/2867423286742310.1076/enst.82.2.115.959510.1080/00138380601042675"A plague o' both your houses: error in GCSE exam paper forces apology""Juliet of the Five O'Clock Shadow, and Other Wonders"10.2307/33912430027-4321339124310.2307/28487440038-7134284874410.2307/29123140149-661129123144728341M"Weekender Guide: Shakespeare on The Drive""balcony"UK public library membership"romeo"UK public library membership10.1017/CCOL9780521844291"Post-Zionist Critique on Israel and the Palestinians Part III: Popular Culture"10.2307/25379071533-86140377-919X2537907"Capulets and Montagues: UK exam board admit mixing names up in Romeo and Juliet paper"Istoria Novellamente Ritrovata di Due Nobili Amanti2027/mdp.390150822329610820-750X"GCSE exam error: Board accidentally rewrites Shakespeare"10.2307/29176390149-66112917639"Exam board apologises after error in English GCSE paper which confused characters in Shakespeare's Romeo and Juliet""From Mariotto and Ganozza to Romeo and Guilietta: Metamorphoses of a Renaissance Tale"10.2307/37323537323510.2307/2867455286745510.2307/28678912867891"10 Questions for Taylor Swift"10.2307/28680922868092"Haymarket Theatre""The Zeffirelli Way: Revealing Talk by Florentine Director""Michael Smuin: 1938-2007 / Prolific dance director had showy career"The Life and Art of Edwin BoothRomeo and JulietRomeo and JulietRomeo and JulietRomeo and JulietEasy Read Romeo and JulietRomeo and Julieteeecb12003684p(data)4099369-3n8211610759dbe00d-a9e2-41a3-b2c1-977dd692899302814385X313670221313670221