Detecting if an element is found inside a container The Next CEO of Stack Overflowcontains() algorithm for std::vectorSimple container class with templatesPolymorphic STL foreach without passing the container typeGeneric container assignmentC++11 Quicksort any containerTriple-type template containerCreating a custom template container class (vector alike)Shift an element in a circular containerNon-sequential template class container C++Internal Zip-like IteratorBasic binary number container

How can I quit an app using Terminal?

Can a caster that cast Polymorph on themselves stop concentrating at any point even if their Int is low?

What happens if you roll doubles 3 times then land on "Go to jail?"

How do I construct this japanese bowl?

I believe this to be a fraud - hired, then asked to cash check and send cash as Bitcoin

How easy is it to start Magic from scratch?

Whats the best way to handle refactoring a big file?

Why didn't Khan get resurrected in the Genesis Explosion?

How do I get the green key off the shelf in the Dobby level of Lego Harry Potter 2?

How do scammers retract money, while you can’t?

Return the Closest Prime Number

Only print output after finding pattern

Why do professional authors make "consistency" mistakes? And how to avoid them?

Text adventure game code

Inappropriate reference requests from Journal reviewers

MAZDA 3 2006 (UK) - poor acceleration then takes off at 3250 revs

Why do remote companies require working in the US?

Does it take more energy to get to Venus or to Mars?

When did Lisp start using symbols for arithmetic?

Grabbing quick drinks

Anatomically Correct Strange Women In Ponds Distributing Swords

What can we do to stop prior company from asking us questions?

Describing a person. What needs to be mentioned?

Can I equip Skullclamp on a creature I am sacrificing?



Detecting if an element is found inside a container



The Next CEO of Stack Overflowcontains() algorithm for std::vectorSimple container class with templatesPolymorphic STL foreach without passing the container typeGeneric container assignmentC++11 Quicksort any containerTriple-type template containerCreating a custom template container class (vector alike)Shift an element in a circular containerNon-sequential template class container C++Internal Zip-like IteratorBasic binary number container










4












$begingroup$


I just wrote this template to detect if a given element is found inside a container:



template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

for (; begin != end; ++begin)

if (*begin == object)

return true;


return false;



Which then would be called for examples as:



bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










share|improve this question







New contributor




Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    4












    $begingroup$


    I just wrote this template to detect if a given element is found inside a container:



    template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

    for (; begin != end; ++begin)

    if (*begin == object)

    return true;


    return false;



    Which then would be called for examples as:



    bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


    This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










    share|improve this question







    New contributor




    Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      4












      4








      4





      $begingroup$


      I just wrote this template to detect if a given element is found inside a container:



      template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

      for (; begin != end; ++begin)

      if (*begin == object)

      return true;


      return false;



      Which then would be called for examples as:



      bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


      This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.










      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I just wrote this template to detect if a given element is found inside a container:



      template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)

      for (; begin != end; ++begin)

      if (*begin == object)

      return true;


      return false;



      Which then would be called for examples as:



      bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);


      This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.







      c++ beginner template






      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked yesterday









      Daniel DuqueDaniel Duque

      555




      555




      New contributor




      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          2 Answers
          2






          active

          oldest

          votes


















          8












          $begingroup$

          Note that for functions the compiler will detect the template types based on the parameters.

          So you can simply write:



          bool test = is_contained(container.begin(), container.end(), anything);


          I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



          template <typename Iterator, typename Value>
          bool is_contained(Iterator begin, Iterator end, Value const& object);


          Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






          share|improve this answer









          $endgroup$




















            5












            $begingroup$


            1. Do you want to test whether an element is in a container, or an iterator-range?



              • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

              • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



            2. Constraining the needle to the type decltype(*begin) is very problematic:



              • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

              • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

              • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


            3. Consider taking advantage of the standard library, specifically std::find ().


            4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






            share|improve this answer









            $endgroup$












            • $begingroup$
              On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
              $endgroup$
              – Toby Speight
              4 hours ago











            Your Answer





            StackExchange.ifUsing("editor", function ()
            return StackExchange.using("mathjaxEditing", function ()
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            );
            );
            , "mathjax-editing");

            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );






            Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.









            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            8












            $begingroup$

            Note that for functions the compiler will detect the template types based on the parameters.

            So you can simply write:



            bool test = is_contained(container.begin(), container.end(), anything);


            I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



            template <typename Iterator, typename Value>
            bool is_contained(Iterator begin, Iterator end, Value const& object);


            Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






            share|improve this answer









            $endgroup$

















              8












              $begingroup$

              Note that for functions the compiler will detect the template types based on the parameters.

              So you can simply write:



              bool test = is_contained(container.begin(), container.end(), anything);


              I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



              template <typename Iterator, typename Value>
              bool is_contained(Iterator begin, Iterator end, Value const& object);


              Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






              share|improve this answer









              $endgroup$















                8












                8








                8





                $begingroup$

                Note that for functions the compiler will detect the template types based on the parameters.

                So you can simply write:



                bool test = is_contained(container.begin(), container.end(), anything);


                I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



                template <typename Iterator, typename Value>
                bool is_contained(Iterator begin, Iterator end, Value const& object);


                Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).






                share|improve this answer









                $endgroup$



                Note that for functions the compiler will detect the template types based on the parameters.

                So you can simply write:



                bool test = is_contained(container.begin(), container.end(), anything);


                I don't particularly like the use of decltype in your function. I would simply make it another template parameter.



                template <typename Iterator, typename Value>
                bool is_contained(Iterator begin, Iterator end, Value const& object);


                Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered yesterday









                Martin YorkMartin York

                74.1k488272




                74.1k488272























                    5












                    $begingroup$


                    1. Do you want to test whether an element is in a container, or an iterator-range?



                      • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                      • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                    2. Constraining the needle to the type decltype(*begin) is very problematic:



                      • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                      • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                      • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                    3. Consider taking advantage of the standard library, specifically std::find ().


                    4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                    share|improve this answer









                    $endgroup$












                    • $begingroup$
                      On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                      $endgroup$
                      – Toby Speight
                      4 hours ago















                    5












                    $begingroup$


                    1. Do you want to test whether an element is in a container, or an iterator-range?



                      • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                      • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                    2. Constraining the needle to the type decltype(*begin) is very problematic:



                      • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                      • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                      • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                    3. Consider taking advantage of the standard library, specifically std::find ().


                    4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                    share|improve this answer









                    $endgroup$












                    • $begingroup$
                      On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                      $endgroup$
                      – Toby Speight
                      4 hours ago













                    5












                    5








                    5





                    $begingroup$


                    1. Do you want to test whether an element is in a container, or an iterator-range?



                      • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                      • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                    2. Constraining the needle to the type decltype(*begin) is very problematic:



                      • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                      • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                      • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                    3. Consider taking advantage of the standard library, specifically std::find ().


                    4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.






                    share|improve this answer









                    $endgroup$




                    1. Do you want to test whether an element is in a container, or an iterator-range?



                      • The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.

                      • The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.



                    2. Constraining the needle to the type decltype(*begin) is very problematic:



                      • It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.

                      • You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.

                      • If the type is a proxy like with the dreaded std::vector <bool>, hilarity ensues.


                    3. Consider taking advantage of the standard library, specifically std::find ().


                    4. C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.







                    share|improve this answer












                    share|improve this answer



                    share|improve this answer










                    answered yesterday









                    DeduplicatorDeduplicator

                    11.8k1950




                    11.8k1950











                    • $begingroup$
                      On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                      $endgroup$
                      – Toby Speight
                      4 hours ago
















                    • $begingroup$
                      On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                      $endgroup$
                      – Toby Speight
                      4 hours ago















                    $begingroup$
                    On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                    $endgroup$
                    – Toby Speight
                    4 hours ago




                    $begingroup$
                    On point 2, it's even worse: you can't pass a value that's convertible to decltype(*begin), because templates need exact matches.
                    $endgroup$
                    – Toby Speight
                    4 hours ago










                    Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.









                    draft saved

                    draft discarded


















                    Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.












                    Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.











                    Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.














                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    រឿង រ៉ូមេអូ និង ហ្ស៊ុយលីយេ សង្ខេបរឿង តួអង្គ បញ្ជីណែនាំ

                    Crop image to path created in TikZ? Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Crop an inserted image?TikZ pictures does not appear in posterImage behind and beyond crop marks?Tikz picture as large as possible on A4 PageTransparency vs image compression dilemmaHow to crop background from image automatically?Image does not cropTikzexternal capturing crop marks when externalizing pgfplots?How to include image path that contains a dollar signCrop image with left size given

                    Romeo and Juliet ContentsCharactersSynopsisSourcesDate and textThemes and motifsCriticism and interpretationLegacyScene by sceneSee alsoNotes and referencesSourcesExternal linksNavigation menu"Consumer Price Index (estimate) 1800–"10.2307/28710160037-3222287101610.1093/res/II.5.31910.2307/45967845967810.2307/2869925286992510.1525/jams.1982.35.3.03a00050"Dada Masilo: South African dancer who breaks the rules"10.1093/res/os-XV.57.1610.2307/28680942868094"Sweet Sorrow: Mann-Korman's Romeo and Juliet Closes Sept. 5 at MN's Ordway"the original10.2307/45957745957710.1017/CCOL0521570476.009"Ram Leela box office collections hit massive Rs 100 crore, pulverises prediction"Archived"Broadway Revival of Romeo and Juliet, Starring Orlando Bloom and Condola Rashad, Will Close Dec. 8"Archived10.1075/jhp.7.1.04hon"Wherefore art thou, Romeo? To make us laugh at Navy Pier"the original10.1093/gmo/9781561592630.article.O006772"Ram-leela Review Roundup: Critics Hail Film as Best Adaptation of Romeo and Juliet"Archived10.2307/31946310047-77293194631"Romeo and Juliet get Twitter treatment""Juliet's Nurse by Lois Leveen""Romeo and Juliet: Orlando Bloom's Broadway Debut Released in Theaters for Valentine's Day"Archived"Romeo and Juliet Has No Balcony"10.1093/gmo/9781561592630.article.O00778110.2307/2867423286742310.1076/enst.82.2.115.959510.1080/00138380601042675"A plague o' both your houses: error in GCSE exam paper forces apology""Juliet of the Five O'Clock Shadow, and Other Wonders"10.2307/33912430027-4321339124310.2307/28487440038-7134284874410.2307/29123140149-661129123144728341M"Weekender Guide: Shakespeare on The Drive""balcony"UK public library membership"romeo"UK public library membership10.1017/CCOL9780521844291"Post-Zionist Critique on Israel and the Palestinians Part III: Popular Culture"10.2307/25379071533-86140377-919X2537907"Capulets and Montagues: UK exam board admit mixing names up in Romeo and Juliet paper"Istoria Novellamente Ritrovata di Due Nobili Amanti2027/mdp.390150822329610820-750X"GCSE exam error: Board accidentally rewrites Shakespeare"10.2307/29176390149-66112917639"Exam board apologises after error in English GCSE paper which confused characters in Shakespeare's Romeo and Juliet""From Mariotto and Ganozza to Romeo and Guilietta: Metamorphoses of a Renaissance Tale"10.2307/37323537323510.2307/2867455286745510.2307/28678912867891"10 Questions for Taylor Swift"10.2307/28680922868092"Haymarket Theatre""The Zeffirelli Way: Revealing Talk by Florentine Director""Michael Smuin: 1938-2007 / Prolific dance director had showy career"The Life and Art of Edwin BoothRomeo and JulietRomeo and JulietRomeo and JulietRomeo and JulietEasy Read Romeo and JulietRomeo and Julieteeecb12003684p(data)4099369-3n8211610759dbe00d-a9e2-41a3-b2c1-977dd692899302814385X313670221313670221